Sébastien Laurent commit tutorials Chapter 1 -> 4#1175
Open
selau-odoo wants to merge 4 commits intoodoo:19.0from
Open
Sébastien Laurent commit tutorials Chapter 1 -> 4#1175selau-odoo wants to merge 4 commits intoodoo:19.0from
selau-odoo wants to merge 4 commits intoodoo:19.0from
Conversation
|
|
selau-odoo
force-pushed
the
19.0-tutorials-selau
branch
from
ee2425d to
3b44f61
Compare
selau-odoo
force-pushed
the
19.0-tutorials-selau
branch
from
3b44f61 to
8c98d46
Compare
AlessandroLupo
left a comment
AlessandroLupo
left a comment
There was a problem hiding this comment.
Nice work! Just a few comments 👍
| @@ -0,0 +1 @@ | |||
| from . import estate_property No newline at end of file | |||
There was a problem hiding this comment.
Please terminate every file with an empty line :)
| _description = "This is my first model" | ||
|
|
||
| name = fields.Char(required=True) | ||
| description = fields.Text() |
There was a problem hiding this comment.
It is not mandatory, but if you want you can add the string argument to every fields method, to describe that field (like you did for garden_orientation)
| @@ -0,0 +1,6 @@ | |||
| { | |||
| 'name': 'Estate', | |||
There was a problem hiding this comment.
If you don't specify a license, you will get a warning in your console when you launch Odoo
estate/__manifest__.py
Outdated
| 'name': 'Estate', | ||
| 'depends': ['base'], | ||
| 'application': True, | ||
| 'data': ['security/ir.model.access.csv'] |
There was a problem hiding this comment.
Here you refer to the file ir.model.access.csv, but this file is created in the next commit. Try to move this line to the next commit too. (Feel free to ask for help with git if you need 😄 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please accept it